Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options

Re(4) (ichimunki): Security issues when allowing file upload via CGI

by dmmiller2k (Chaplain)
on Dec 07, 2001 at 01:50 UTC ( #130085=note: print w/replies, xml ) Need Help??

in reply to Re: Re(2) (ichimunki): Security issues when allowing file upload via CGI
in thread Security issues when allowing file upload via CGI


Yes, you're right about $fn being tainted, but I was speaking more to the principle of using the standard *NIX command, "file" (or reasonable facsimile, such as the perl module File::MMagic, for example) to check the type of the file by examining the first several bytes (or more).

Certainly, by the time I intended this code to run, a file would have been uploaded to some directory somewhere. My expectation was that $fn would, at the time of the call, contain the full pathname to this file, and would not necessarily have been entered directly by a web-page user.

But then, I DID fail to document these expectations (read: preconditions, using programming-by-contract terminology), so I deserve to be chastised for it.

(takes 40 lashes with a wet noodle)


You can give a man a fish and feed him for a day ...
Or, you can teach him to fish and feed him for a lifetime

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://130085]
and the monks are chillaxin'...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (12)
As of 2017-01-24 16:06 GMT
Find Nodes?
    Voting Booth?
    Do you watch meteor showers?

    Results (207 votes). Check out past polls.