Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re: How do you critique another person's code?

by Masem (Monsignor)
on Dec 19, 2001 at 23:01 UTC ( #133215=note: print w/ replies, xml ) Need Help??


in reply to How do you critique another person's code?

Besides keeping a cool head, start with the issues that are going to end up as potental bugs; the file1/file2 array assignments for example, with the lack of definition for cnts. The phone number trick will also possibly be a source of problems later.

Then refer to the code that is inefficient but where it's obvious the programmer knows a more efficient method. In this case, for example, the dealercode could be generated from the substr function, which he's used previously, with much less code and storage overhead.

Note that you shouldn't refer much to *style* (specifically the variable naming implied, the comments, or to some extent the HTML inclusion w/o using CGI's HTML) unless it's against the company policy. Style's something that is a personal feel, and issues that deal with style should not have a very large impact on speed or execution of the code.

Finally, make sure to look for *good* things in the code as well. While code critique implies "negative elements", try to find something that the programmer appears to have done well. Don't try too hard to find something good about it, of course, but if there is something that impresses you, make sure you note that.

-----------------------------------------------------
Dr. Michael K. Neylon - mneylon-pm@masemware.com || "You've left the lens cap of your mind on again, Pinky" - The Brain
"I can see my house from here!"
It's not what you know, but knowing how to find it if you don't know that's important


Comment on Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133215]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (4)
As of 2014-11-27 20:11 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My preferred Perl binaries come from:














    Results (187 votes), past polls