Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re: How do you critique another person's code?

by maverick (Curate)
on Dec 19, 2001 at 23:36 UTC ( #133232=note: print w/replies, xml ) Need Help??


in reply to How do you critique another person's code?

Along with everything else advised here...try to always keep the tone of reviewing the code and not the coder. This can be very tricky..and you'll have to phrase what you say with some thought. Unless the programmer has had his/her code reviewed before and comes into the meeting understanding that this is about helping his/her code be better, s/he is likely to take everything you say as a personal attack. This chunk of code is their creation and thus some programmers are very prideful of that and take great offense to anyone saying something bad about it.

Unless the other managers are also aware of this (and you may have to prep them), they can inadvertantly torpedo even your most carefully worded phrases.

For everything you find wrong, have a suggestion for how to improve it. Make the tone of the meeting be more like "we're offering our help to improve your skills and help you be a better programmer" instead of "Here's all the bad things you did, fix them and don't do it again".

Good luck

/\/\averick
perl -l -e "eval pack('h*','072796e6470272f2c5f2c5166756279636b672');"

  • Comment on Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133232]
help
Chatterbox?
[RonW]: Is there an English language version of the site?
[LanX]: but Afaik Perl is on average about 10-20 times slower than C
[LanX]: no
[LanX]: but I could ask Herbert to elaborate
[1nickt]: http://rperl.org/ performance_benchm arks.html
[RonW]: 1nickt: Thanks. Looking at that

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (6)
As of 2017-05-22 20:19 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?