Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Re: How do you critique another person's code?

by perrin (Chancellor)
on Dec 19, 2001 at 23:37 UTC ( #133233=note: print w/replies, xml ) Need Help??

in reply to How do you critique another person's code?

Code reviews are hard. That's because it's really hard to take someone else picking at your code the first few times it happens. I've had a hard time accepting criticisms in code reviews, and I know how important it is to have them and to listen.

My advice is to think about how you would feel on the other side of the table and act accordingly. Be as nice as you can about it, or the guy will reject everything you say out of spite.

It's also a good idea for your company to invest some money into training resources for this guy. Maybe a good book about style and maintenance issues, like Code Complete. Maybe let him ride a more competent coder's coattails for a bit, doing maintenance on some solid code. I learned a lot that way.

  • Comment on Re: How do you critique another person's code?

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133233]
[LanX]: several people told me they like saigon. ..
[choroba]: well, beer is good here, surprisingly
[choroba]: also, I discovered several vegan/vegetarian restaurants, so I can avoid meat
[LanX]: ha ha ... happy Czech :)
[choroba]: been to the War Remnants Museum, too. Quite a brutal experience
[choroba]: but still, small-talk about smuggling guns and how Trump is great with US expats isn't my cup of tea
[LanX]: brutal beer?
[LanX]: met a Canadian yesterday, he suggested building a wall and let the US pay for it

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (5)
As of 2017-02-26 04:35 GMT
Find Nodes?
    Voting Booth?
    Before electricity was invented, what was the Electric Eel called?

    Results (371 votes). Check out past polls.