Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Re: How do you critique another person's code?

by George_Sherston (Vicar)
on Dec 19, 2001 at 23:39 UTC ( #133234=note: print w/replies, xml ) Need Help??


in reply to How do you critique another person's code?

Thanks for sharing that in such detail. Painful but entertaining, particularly the comments. And always worthwhile: a lesson in folly is worth two in wisdom as the man said.

As to tackling the feedback, my only observation wd be be as specific as possible. I think people who do a lot of programming know that abstract, aesthetic issues in code really do matter - they are very good pointers not just to little niggles but to systemic disasters that will happen. But for people who don't think that way, the most persuasive criticisms are, IMHO, ones of the form "This line of code would, under such-and-such circumstances, give rise to this specific bad thing happening".

Having said that, Draino in the chap's coffee is probably a good fallback plan. Good luck!

George Sherston
  • Comment on Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133234]
help
Chatterbox?
[perldigious]: A question since I'm ignorant of what's normal for database management... Do admins change column names a lot in databases?
[perldigious]: On occasion my scripts break, because they will do something that seems laregly pointless to me... like in this case, changing a column name from "ABC Category" to "ABC Category Override".
[perldigious]: Being the ignorant one, my initial reaction to that is, "that's sort of a dick move, a lot of people like me expect column names like that to stay the same, why the hell would you change them like that for seemingly no good reason?"
[perldigious]: Or is my irritation/ frustration well founded?
[Corion]: perldigious: That seems to be more the export and likely it's the recipients of that export that like the titles changes
[Corion]: ... "changed"
[Corion]: I usually expect fixed header names, but am sometimes lenient in the order of columns. But changing the report titles often sounds to me as if you are not the sole consument of the export ;)

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (5)
As of 2017-05-25 13:31 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?