Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?
 
PerlMonks  

(ichimunki) Re: How do you critique another person's code?

by ichimunki (Priest)
on Dec 20, 2001 at 00:15 UTC ( #133245=note: print w/ replies, xml ) Need Help??


in reply to How do you critique another person's code?

I'm not even going to comment on the crappy code which appears to be deliberate sabotage of any future attempts at maintenance or re-use. The first two comments are completely useless. If it's obvious the naming sucks by looking at it, why comment the fact? Only the third of the four comments you quote is even remotely worthwhile. I could see myself including a note like that to myself in code, except that the fourth comment is flat out abusive.

Coupled with the obvious and deliberate attempts in the actual code to confound future coders, this points to issues far depper than this individual's apparent lack of programming talent. It's not as though this were some brilliant obfuscation that ran in eight lines of code and as many milliseconds-- this is someone who should not be programming for a living. After all, his/her deliberately foul code was performing so poorly that it was taken out for review.


Comment on (ichimunki) Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133245]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (11)
As of 2014-12-28 19:59 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (182 votes), past polls