Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

(ichimunki) Re: How do you critique another person's code?

by ichimunki (Priest)
on Dec 20, 2001 at 00:15 UTC ( #133245=note: print w/replies, xml ) Need Help??


in reply to How do you critique another person's code?

I'm not even going to comment on the crappy code which appears to be deliberate sabotage of any future attempts at maintenance or re-use. The first two comments are completely useless. If it's obvious the naming sucks by looking at it, why comment the fact? Only the third of the four comments you quote is even remotely worthwhile. I could see myself including a note like that to myself in code, except that the fourth comment is flat out abusive.

Coupled with the obvious and deliberate attempts in the actual code to confound future coders, this points to issues far depper than this individual's apparent lack of programming talent. It's not as though this were some brilliant obfuscation that ran in eight lines of code and as many milliseconds-- this is someone who should not be programming for a living. After all, his/her deliberately foul code was performing so poorly that it was taken out for review.
  • Comment on (ichimunki) Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133245]
help
Chatterbox?
[Corion]: Oh yay. The (external, not guided by me) programmers have chosen Moose+DBIx::Class for some implementation, and now seem to do 1+n SELECT statements for each row, as is usual when using ORMs.
[Corion]: So maybe I should investigate how to plug in a cache in front of DBIx::Class so I can do a ->selectall_hashre f and then satisfy the "sub"-selects from that cached single SELECT statement ...

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (6)
As of 2017-09-25 10:54 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    During the recent solar eclipse, I:









    Results (279 votes). Check out past polls.

    Notices?