Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

Re: How do you critique another person's code?

by Juerd (Abbot)
on Dec 20, 2001 at 00:17 UTC ( #133248=note: print w/ replies, xml ) Need Help??


in reply to How do you critique another person's code?

## yes, the naming convention sucks, but hey, you didn't program it, I did
## come on now, I wrote the code, like there would ever be a problem. he he he

This reminds me of some comment in the MS fdisk source code:

cmd\fdisk\fdisk.c /* P.S. - To whoever winds up maintaining this, I will */ /* apoligize in advance. I had just learned 'C' when */ /* writing this, so out of ignorance of the finer points*/ /* of the langauge I did a lot of things by brute force.*/ /* Hope this doesn't mess you up too much - MT 5/20/86 */ cmd\fdisk\profile.h #define BEGIN { #define END }

I've got to admit the Microsoft programmer did a much better job: he apologized and respected the reader of his source code.
(You might wonder where I got this from - A few months ago, someone gave me a text file with some quotes from the MS DOS 6.0 source code. I can't check if they're genuine, but a google search showed some hits, so I guess it's real.)

BTW, I like the part where the programmer says that those who don't understand his source should not be programming.

2;0 juerd@ouranos:~$ perl -e'undef christmas' Segmentation fault 2;139 juerd@ouranos:~$


Comment on Re: How do you critique another person's code?
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133248]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (19)
As of 2014-07-31 19:02 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (251 votes), past polls