Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: Re: How do you critique another person's code?

by archen (Pilgrim)
on Dec 21, 2001 at 00:33 UTC ( #133598=note: print w/replies, xml ) Need Help??


in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?

Do you like your job? Not to be a smart-ass, but this sounds really bad to me. ESPECIALLY other people going along with it. Now the other stuff is up to your boss I guess, but I find the "over commented" part hard to swallow. I mean comments are what allow people to easily look at code without thinking "what was the guy who wrote this trying to do". To me this all sounds like a formula for disaster down the road. I'm not sure I'd be too particular on a boss ripping my code in front of everyone for being too clear either.
  • Comment on Re: Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133598]
help
Chatterbox?
[Lady_Aleena]: Why does grep(/.*$in.*/, @my_modules) work but grep { $_ =~ /.*$in.*/; $_ } @my_modules not work? What did I do wrong in the second?
[tobyink]: Why are you returning $_ n your grep block? You should return a boolean.
[tobyink]: *in your grep block

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (6)
As of 2017-05-27 07:35 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?