Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Simplifying repetitive flow structures

by admiralh (Sexton)
on Apr 01, 2002 at 16:55 UTC ( #155795=note: print w/replies, xml ) Need Help??

in reply to Simplifying repetitive flow structures

The main thing you need to do here is abstract out all the commonalities. From my eyeballing, it seems that the only thing changing is the contents of the Tr data.

Try this

my $td_ref; if ($type eq 'f') { if ($ref->{'pic'}) { $td_ref = [$q->a({href=>"$ref->{'pic'}"}, $ref->{'name'}), $ref->{'phone'}, $ref->{'fax'}, $ref->{'loc'}, $q->a({href=>"mailto:$ref->{'email'}"}, $ref->{'email'} +) ]; } else { $td_ref = ["<LI>".$ref->{'name'}, $ref->{'phone'}, $ref->{'fax'}, $ref->{'loc'}, $q->a({href=>"mailto:$ref->{'email'}"},$ref->{'email'}) ]; } } elsif ($type eq 'c') { # and so on ... } print $q->Tr([$q->td({-bgcolor=>$cellcolor},$td_ref)]);
I also added a bit of spacing for readibility.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://155795]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (10)
As of 2016-10-21 15:00 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (289 votes). Check out past polls.