Re: C vs perl

[Ovid]

Well, I can't comment on the C code, but I think you can make the Perl a bit clearer (or at least more correct). The following assumes that you want each <p>...</p> section on a new line. If not, the final join should be on an empty string.

sub MakePtag{
  my $fixme = shift;           # take in our parameters
  return join "\r\n",          # join with newlines
    map  { "<p>$_</p>" }       # wrap each line in <p></p> tags
    grep { /\S/ }              # must have at least one non-whitespace
+ character
    split "\r\n", $fixme;      # break apart on the newlines
}

Of course, I'd be shot for suggesting:

sub MakePtag { join "\r\n", map {"<p>$_</p>"} grep {/\S/} split "\r\n"
+, $_[0] } # :)

If you stick with your solution, you'll want to chomp $fixme to avoid wasted tags on the end. Oh, and you had the slash on the trailing paragraph tag backwards :)

sub MakePtag{
  chomp(my $fixme = shift;)    # take in our parameters
  $fixme=~s|(\r\n)|</p><p>|g;  # replace all \r\n with <\p><p>
  $fixme = "<p>$fixme</p>";    # Add beginning and ending tags
  return $fixme;                
}

Interesting question: what hoops would you have to just through with C to duplicate the grep functionality that I tossed in?

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.