All code correctly solves some problem. It all does something. But, without telling us what problem you're trying to solve, we're unlikely to be able to tell you what is wrong with the code :)

Exactly what is the above supposed to do?

Sorry - in case the above sounded a bit sniffy, you've not told us:

• Whether you are converting bits to bytes, or de-huffman coding,
• What endianness the data is,

...etc... - there could be many, non-obvious, reasons that code isn't working.

$cur_node = $cur_bit ? $cur_node->right : $cur_node->left;
[download]

But I could be way off base on this one: I don't know much about Huffman encoding. If you post more of your code, some other monks might dig in and offer some more meaningful advice.

hth, and welcome to the monastery!
blyman
setenv EXINIT 'set noai ts=2'

You're leaving a lot of information out of the question, but one can guess that you want to do huffman decoding.

I assume that your huffman tree has nodes with methods left,right, value. So $node->value() is probably going to return a binary number - I would imagine in fact that your put_stream method is where this should go but basically you just want to do: chr(oct("0b".$cur_node->value)); See 15577 for info on converting to decimal from binary. Some error checking to make sure you aren't producing a number > 255 before calling chr would be in order too.

Can't do a whole lot else to help without some more info.

Update: Course as kal says, need to know the endianess of your data otherwise that won't work.

We really need to see what you constructed for the get_bit() and put_stream() routines and how you constructed your hash tree.

If you still don't understand how this works after you get the typos fixed, I'm sure we can discuss how this walks down a tree looking for nodes, checking whether a node contains a value or a link/reference to another node, and outputting any values found or following the link/reference to the next node depending on what it finds in the current node. :)