Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine

Re: strict isn't everything

by Dog and Pony (Priest)
on Jun 11, 2002 at 17:52 UTC ( #173590=note: print w/replies, xml ) Need Help??

in reply to strict isn't everything

Ok, I'm not too good at this, so I thought this might be a good time to practice then. I found a few things I found curious, although I can't be 100% sure they are wrong, so I'll just post them and see if I hit any marks. :)

Here's one I am not sure about:

I would, at a wild guess, think that if uploading resumés, and with the same name, they would, if anything, replace the old one - or be disallowed. This appends to an earlier file, which just seems wrong. I can guess the file will be deleted when this script is done, but this allows for strange effects. Using a unique temporary name would have been better, if the file should not stay there, or to check for duplicates if it should stay. File locking could be yet another way to go.

This, I wonder if it may have other implications elsewhere?

$CGI::DISABLE_UPLOADS = 0; # Temporarily reenable up
I'm not really sure how this works with and all, or how the rest of the code/system looks, but maybe a "local" would have helped?

I don't get this one either:

if ( $stats[7] > MAX_FILE_SIZE || %errors ) { $errors{'file_size'} = ["","","Your submitted file's size is over 3M +B."];
If there are errors, you automatically have too big file size? That ought to confuse a few... :)

This is an odd check:

if( $file_type =~ /octet-stream/ ) { $errors{ 'file_type' } = ["","","Unrecognize your submitted resume f +ile format."]; goto Print; }
There must be more non-allowed file types, or did he mean "!~"?

I'm sure I missed all the real errors, and pointed out perfectly legitimate stuff, but if that is so, I hope to learn something from the grind-my-face-in-the-ground treatment I am gonna get. :)

You have moved into a dark place.
It is pitch black. You are likely to be eaten by a grue.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://173590]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (2)
As of 2018-01-19 04:35 GMT
Find Nodes?
    Voting Booth?
    How did you see in the new year?

    Results (215 votes). Check out past polls.