Re: Shell Menu Code Review

[Chmrr]

in reply to Shell Menu Code Review

If this is meant to restrict user access (ie users are not allowed a command line) then you might want to be more leery about your system("ppp -direct $server") -- what if they type "some.server.org && bash" as the server to connect to? The multiple argument form of system will tend to avoid such problems.

Other than that, looks good.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'

[PrimeLord]

saouq and Chmrr,

Thanks for pointing that out. I hadn't even thought about the fact they could pass anything they wanted into that system call. I am going to change that so it just presents them with a list of servers to connect from.

-Prime