Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re: Shell Menu Code Review

by Chmrr (Vicar)
on Jul 25, 2002 at 19:14 UTC ( #185293=note: print w/replies, xml ) Need Help??

in reply to Shell Menu Code Review

If this is meant to restrict user access (ie users are not allowed a command line) then you might want to be more leery about your system("ppp -direct $server") -- what if they type " && bash" as the server to connect to? The multiple argument form of system will tend to avoid such problems.

Other than that, looks good.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'

Replies are listed 'Best First'.
Re: Re: Shell Menu Code Review
by PrimeLord (Pilgrim) on Jul 25, 2002 at 19:43 UTC
    saouq and Chmrr,

    Thanks for pointing that out. I hadn't even thought about the fact they could pass anything they wanted into that system call. I am going to change that so it just presents them with a list of servers to connect from.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://185293]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (5)
As of 2016-10-22 19:59 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (297 votes). Check out past polls.