Re: Re: Z80 Assembler -> Hex Opcode

[Elgon]

Hi Tachyon,

I did indeed realise this, however in the code as you have written it the declaration of %opcodes is in a different scope to that of the subroutine and hence, all you get returned is an error. I am not sure exactly how to access the hash from the subroutine's scope - %main::opcodes ???

I did also originally run the program without the encode routines as a separate sub and it didn't appear to run any faster.

Thanks,

Elgon

Update: I tried running the program as a simple loop, without the sub as before, and it took about 1 second instead of 36 or so to run. Must have declared the hash inside the loop the first time. Oops. Time to go back to the Blue Camel and re-read the sections on scoping and packages :-)

Update^2: I've been trying to do what you suggest by passing a reference to %opcodes to the subroutine along with the line and then saying local *hash = shift; a la blue camel page 294 but this isn't liked either. FYI I'm using Perl 5.005 so use of our is right out.

Update^3: See root node.

"What this book tells me is that goose-stepping morons, such as yourself, should read books instead of burning them."
       - Dr. Jones Snr, Indiana Jones and the Last Crusade

[tachyon]

With the example I posted %opcodes is in main::, so too the sub is in main:: - ergo and therefore same scope, no errors, runs as posted. You don't need the use vars *and* the my declaration for %opcodes. One or the other will pacify strict...

# declare this in implicit main:: package
my %here = ( in => ' main' );

run();

sub run { 
    # we are still in main:: here, so we can access %hash just fine
    print "I am still ", %here 
}

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

[Elgon]

Ah, found the problem,

a) poor understanding of scoping on my part and b) when I first ran as you described, I had the declaration of %opcodes after the main loop containing the call to encode() so, in effect, the declaration never took place until after the program had effectively run its course.

You live and learn.

Elgon

"What this book tells me is that goose-stepping morons, such as yourself, should read books instead of burning them."
       - Dr. Jones Snr, Indiana Jones and the Last Crusade

[tachyon]

Declaring hash structures within subs that get repeatedly called is a common problem. Another solution that allows the hash to be declared on demand (if the sub may or may not be called this is good) but still only be called once is to use a closure like this:

{
    my %hash;
   
    sub my_sub {
        unless (%hash) {
            %hash = ( blah );
        }
    }
}

# %hash is not accessible here, this is a different one
my %hash...

Doing it this way makes %hash private to the sub as the my delaration localises it to the bare block where it is accessible to the sub but not main:: per se. You start the sub by checking if the hash is populated. On the first call to the sub it will not be so you set it. From then on it will populated so you don't need to set it again during subsequent calls to the sub. Perl retains a reference to it between calls to the sub so it never gets garbage collected.

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print