Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine

Re: finding and deleting an element from array

by benn (Priest)
on Sep 05, 2003 at 15:13 UTC ( #289236=note: print w/ replies, xml ) Need Help??

in reply to finding and deleting an element from array

More as a general point about this class of problem, it's my turn to repeat the well-worn advice about "whenever you start finding yourself with variables ending with incremental numbers, it's time to use arrays instead."

There's nothing at all wrong with assigning an array to a grep'ed version of itself, any more than there is map'ing one - you really don't need @cards1, @cards2 etc.

As Zaxo said, shuffling and popping would be better here, but should you wish to do this (or similar) "in place" as you are doing, something like this would be easier...

while (@hand < $num_to_deal) { return "no more cards" unless @cards; push @hand,$cards[int(rand(@cards))]; @cards = grep{$_ ne $hand[$#hand]}@cards; }
NB - I'm not advocating this code - as others have said, the grep is nasty - just pointing out a principle :)

Cheers, Ben.

Comment on Re: finding and deleting an element from array
Download Code

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://289236]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (8)
As of 2015-11-25 17:15 GMT
Find Nodes?
    Voting Booth?

    What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

    Results (683 votes), past polls