Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

RE: RE: RE: Code Review section, anyone?

by swiftone (Curate)
on Sep 14, 2000 at 19:42 UTC ( #32483=note: print w/replies, xml ) Need Help??

in reply to RE: RE: Code Review section, anyone?
in thread Code Review section, anyone?

Okay, let me see if I understand completely:

You want a section that is different from Seekers of Perl Wisdom in that:

  1. It is explicitly for reviewing working code
  2. The posters are aware that the code is there to be reviewed
  3. Replies can be private
If this is indeed what you want, I would overall have no problem with it, except:
  1. I see no reason for private feedback. PerlMonks is about sharing learning, and this could be an excellent learning opportunity for more than the poster
  2. This would be best accomplished by revising the Code Catacombs section. As it stands, there is no real distinction made between Code Catacombs, Craft, and Snippets. Rather than adding a new section, I would modify one of those existing ones.
If I am now understanding your wishes, and with the above comments, I think this is a great idea. You mentioned something in the chatterbox yesterday about what you considered good/bad usage of the ? : construction during a code-review, and I found it interesting. Where I work I'm the only Perl programmer, and there is nothing resembling a code review. My only reason for writing good code is that I have to maintain it, and my only means of learning new tricks is reading books and PerlMonks. I know I would benefit from code review, and I imagine others would too.

All of this is IMNSHO, of course.

  • Comment on RE: RE: RE: Code Review section, anyone?

Replies are listed 'Best First'.
RE: RE: RE: RE: Code Review section, anyone?
by merlyn (Sage) on Sep 14, 2000 at 19:44 UTC
    Yes, I like the idea of scrapping code catacombs and renaming it Code Review, maybe with a monkish sort of name.

    As for private feedback, I don't know what made me think that, and I can't remember now. {grin}

    -- Randal L. Schwartz, Perl hacker

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://32483]
[pryrt]: The mismatched ones have a Jan 23 2017 Last-Modified header -- I wonder if they rezipped them and forgot to update the sha1
[stevieb]: RT ticket for the csum mismatch of various versions of Strawberry Perl

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (3)
As of 2017-03-29 21:10 GMT
Find Nodes?
    Voting Booth?
    Should Pluto Get Its Planethood Back?

    Results (353 votes). Check out past polls.