comment on

Hello all, I can't seem to get the correct syntak to check for NO items on the command line.

#!/usr/local/ActivePerl-5.16/bin/perl

use POSIX qw/strftime/;


sub fixdir {
    my $dir = shift;
    opendir my $DH, $dir or die "Not Found....$dir: $!";
    while (my $f = readdir $DH) {
        next if grep $_ eq $f, qw/. ../;
        (my $new = $f) =~ s/[^a-zA-Z0-9_.]/_/g;
        next if ($new eq $f);
        while ( -e "$dir/$new") { $new .= "1";  }
        print STDERR "Renaming: $f -> $new\n";
        rename "$dir/$f", "$dir/$new";
        fixdir("$dir/$new") if -d "$dir/$new";
    }
}


$Do_Dir = @ARGV[0];
print("ARG=", "$Do_Dir", "<<<<<<\n");
if ("$Do_Dir" == null ) {
    print ("No Folder Name given!\n");
    exit; }
print( "The Folder Name is: ", "$Do_Dir", "\n" );
fixdir($Do_Dir);
print "Done..."

produces this....
9858-215-rfleisch:test_it p00015282$ ./Change_FName2.pl these
ARG=these<<<<<<
No Folder Name given!
9858-215-rfleisch:test_it p00015282$ ./Change_FName2.pl
ARG=<<<<<<
No Folder Name given!
9858-215-rfleisch:test_it p00015282$ 

Notice the SAME results ????????
[download]

Thank.... -Ray

In reply to Check For null Arguments by rfleisch

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


We don't bite newbies here... much
	PerlMonks