Hello Nige,
Thanks for that, it looks useful.
A few minor points:
- Although your code is, in fact, strict-compliant, it would be better to make this explicit with use strict;
- Since you’re not using the list returned by map, it would probably be clearer to use a for loop here:
s/^(0x|#)(.{6})/$2/ for @hexSs;
- The statement print "</TR>\n</TR>" is probably meant to be print "</TR>\n<TR>" (i.e. ending the last table row and beginning another)
- When comparing numbers, use > rather than gt (which is for stringwise comparison)
- Although the comparison is with 4, the logic actually prints 6 cells per row. I think the following is clearer:
my $cell = 0;
for my $hex (@hexSs)
{
print "<TD BGCOLOR='#$hex'>",
"<FONT COLOR='white'>$hex</FONT><BR /><BR />",
"<FONT COLOR='black'>$hex</FONT></TD>";
if (++$cell >= 6)
{
$cell = 0;
print "</TR>\n<TR>";
}
}
Hope that helps,
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|