open(OUTPUT,">>${len}.words");
while(<>){
chomp($_);
$len = length($_);
print OUTPUT "$_\n";
}
close(OUTPUT);
This doesn't do what the others do. For one, $len isn't defined before the
open. Secondly, you don't have an outer loop involved to be able to re-open the files as needed.
Secondly, if you're going to use $_, then use it. Don't piddle around. If you're going to use a named variable (and I'm not saying this is bad), then name it. Otherwise, take advantage of Perl-isms.
while (<>) {
chomp;
my $len = length;
print OUTPUT $_, $/;
}
It wouldn't be nice unless I posted my own (un
Benchmarked) version.
use IO::File;
my %Handles;
while (<>) {
my $handle = $Handles{length} ||= IO::File->new(">" . length - 1);
print $handle $_;
}
# This is unnecessary unless you're anal (like I try to be)
$_->close for values %Handles;
------
We are the carpenters and bricklayers of the Information Age.
Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.