Style issues.
A couple of things that you probably want to keep in mind while coding. First, if you won't use strict, at least be sure to lexically scope your variables by declaring them with my. For example, in your &passhash method, you don't declare your hash, thus making it a package variable and you lose encapsulation.
- Whenever you are doing OO programming, remember that the first argument to the method is the object.
- Be sure to use proper (or at least consisten) indenting to indicate scope.
- Your constructor should use the two-argument form of bless. Otherwise, you can't inherit from this.
package packa;
use strict;
sub new {
my $class = shift;
my $self = {};
bless $self, $class;
return $self;
}
sub pass{
my ( $self, $problem1 )= @_;
print "$problem1\n";
}
sub passhash{
my %hash = qw {
dog voa
cat mice
};
$hash{'problem2'} = [
["ha" , "thing", "thorw"],
["good", "ssa" , "ham"],
["as", "kid", "wo"],
];
return %hash;
}
Hope this helps.
Cheers,
Ovid
Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.