Style, readability and maintainability are much more important in most cases. That's why I always assign @_ to a list of lexicals, unless I'm coding a one-liner. In classes for tie, I often use shift and pop in examples.
sub TIESCALAR { bless \(my $foo = pop), shift; }
sub STORE { ${ +shift } = pop }
sub FETCH { ${ +shift } }
###
sub foo {
my ($self, $foo) = @_;
...
}
sub foobar {
my ($self, %options) = @_;
...
}
If I use @_ and the sub is small (5 lines or less), I do shift the object and then use @_, because that saves me an array. Besides, sometimes you want to change the values, in which case you have to use @_.
Some examples of things that I do not like:
# Bad
sub foo {
my $self = shift;
... not using @_ anymore
}
sub bar {
my $self = shift;
my %options = @_;
...
}
# Worse
sub foo {
my $self = shift;
my $foo = shift;
my $bar = shift;
...
}
# Awful
sub foo {
my $self = shift;
my $foo = shift;
...
my $bar = shift;
...
}
I dislike anything using more than one
shift.
- Yes, I reinvent wheels.
- Spam: Visit eurotraQ.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.