Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
A few comments, which I hope will be helpful:
  • When you have multiple output files open at one time, and use "select FILEHANDLE" on one, then another, you're inviting confusion about where a given 'print $string' is really going.
  • When your print statements are using the same string over and over (e.g. '<DOCTYPE>...'), it makes sense to assign that string to a variable, and use the variable in all those print statements.
  • Try to write a brief, simple pseudo-code version of your app, and see if it leads you to compartmentalize things a little better (e.g. to put some portions of code into subroutines).

I don't know why you got the error that you reported (earlier comments about an open failure that you didn't check for are probably on the mark), but I would like to offer this pseudo-code summary as an example that arranges things a little differently and may suggest some ways to write the code more economically:
connect_to_db or die prepare_query or die open_master_page or die print_master_page_header $artist_page_open = ""; while ( query_returns_a_row ) { if ( $artist_page_open ne this_artist ) { if ( $artist_page_open ne "" ) { print_artist_page_trailer close_artist_page or die } open_artist_page or die print_artist_page_header $artist_page_open = this_artist } print_artist_page_row print_master_page_row } close_db print_artist_page_trailer print_master_page_trailer
I'm not saying everything should be a subroutine; but as you start to put details into the stubs and you find things that they have in common, it'll be easier to factor those common things into subs, so you only have to code each one once.

In reply to Re: Question about Open and Close by graff
in thread Question about Open and Close by Ebany

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others about the Monastery: (5)
As of 2024-04-24 10:09 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found