Two comments:

1. Leave off the else if you don't use it. Including unused code is usually begging for confusion later on.
2. Are you sure your code above is correct? You have an assignment operator "=" instead of a logical operator like "==" or "eq".

The second point is significant (and if it was just a typo, I'll complete this thought for others because I've tripped on this a time or two).

Consider the following code:

$x = 3;
$y = "Ovid";
if ($x = $y) {
    print "This is true\n";
} else {
    print "This is false\n";
}
[download]

This code will always print "This is true" because the "=" assigns the value of $y to $x (in this case, both wind up with the value of "Ovid"). The if statement winds up evaluating the true/false value of "Ovid" and concludes because it is not undef and not zero, it must be true and the statement prints. Therefore, the above code probably doesn't behave the way you want it to.

Interestingly, the following snippet will work the way you expect it, but not for the reasons that are immediately obvious:

$x = 3;
$y = 0;
if ($x = $y) {
    print "This is true\n";
} else {
    print "This is false\n";
}
[download]

This code will print "This is false", but not because $x failed to equal $y. In this case, $y is assigned to $x and the if statement evaluated the resulting value, in this case '0' (zero) and zero evaluates as false.

Always remember when using an if statement or other conditional that you usually want to test equality with a logical operator such as "==" for numerics and "eq" for non-numerics.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.