I think you'll have a problem with the argument structure:
sub revdnacomp {
# my $dna = @_;
# the above means $dna gets the number of
# arguments in @_, since it's a scalar context!
my $dna = shift; # or my $dna = shift @_;
# ah, scalar context of scalar gives expected results.
# my ($dna) = @_; # would work, too
my $revcomp = reverse($dna);
$revcomp =~ tr/ACGTacgt/TGCAtgca/;
return $revcomp;
}
but why not allow the complementation over more than one element?
sub revcompl { # operates on all elements passed in
my (@dna) = @_;
foreach my $segment (@dna) {
my $revcomp = reverse($segment);
$revcomp =~ tr/ACGTacgt/TGCAtgca/;
push @done, $revcomp;
}
return @done; # or reverse @done; # what's best semantics?
}
Did I miss anything?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|