Here's the problem (or one of them):
while (<USEDPW>)
{
my $pw = @chars[map{rand @chars} (1..17)];
}
unless ($_ ne my $usedpw) {
print "Your unique ID is: $pw\n";
}
my $pw;
open(USEDPW, "> $usedpw") or die "crap on me for writing $!";
flock USEDPW, 2;
print USEDPW "$pw\n";
You have 2 separate variables named
$pw. You used
my which is a Good Thing but forgot that
my lexically scopes your variables. That means that the
my $pw inside the
while(<USEDPW>) loop is a completely different variable than the one declared outside the loop.
pfaut fixed it in his
post but didn't tell you why he did it. You need to declare the
$pw variable outside the loop so it stays in scope. For example:
#notice we declare it OUTSIDE the loop
my $pw;
while (<USEDPW>)
{
$pw = @chars[map{rand @chars} (1..17)];
}
unless ($_ ne my $usedpw) {
print "Your unique ID is: $pw\n";
}
open(USEDPW, "> $usedpw") or die "crap on me for writing $!";
flock USEDPW, 2;
print USEDPW "$pw\n";
You should have gotten a "Use of uninitialized value in print" warning when you ran your code.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.