comment on

Your module looks very nice indeed, it is very compatible with XML::Simple, and very easy to use.

I just have one comment: with warnings on, it keeps complaininig. That's a big problem, as it basically forces the user to turn them off.

The 2 main kinds of warning:

Scalar value @stat[3] better written as $stat[3] at /usr/lib/perl5/sit
+e_perl/5.8.0/XML/Smart.pm line 346-425
Use of uninitialized value in pattern match (m//) at /usr/lib/perl5/si
+te_perl/5.8.0/XML/Smart/Tree.pm line 229.
[download]

If you could get rid of those, that would be a great improvement.

In reply to Re: ANNOUNCE: XML::Smart 1.0 by mirod
in thread ANNOUNCE: XML::Smart 1.0 by gmpassos

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Do you know where your variables are?
	PerlMonks