You can write
([a-z]|[0-9])+
also as
([a-z0-9])+
or
[a-z0-9]+
which will save you a lot of capturing clauses if you don't need to capture anything
I didn't analyze the whole regex, but at a first view some questions arised:
x) what's about _ and uppercase letters? -> \w instead of a-z0-9
x) \@{1} is the same as \@ => so {1} can be omitted, also in \.{1}
x) what about user@my-domain.tld ?
x) x.@domain.tld seems ok
BTW: with the flag /x you can write regexes more readable and comment them, e.g.
$mail =~ /^ # at the beginning
[a-zA-z0-9] # one letter or digit
[a-zA-Z0-9_\-\.] # opt. letters, digits, underscores.
\@
[a-zA-z] # one letter
...
$/x;
for scripts in production I like to use Mail::RFC822::Address from CPAN...
Best regards,
perl -e "s>>*F>e=>y)\*martinF)stronat)=>print,print v8.8.8.32.11.32"
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|