Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Let's compare:

$window->title('foo')->border(20); # versus $window->set(title => 'foo', border => 20);

Clearly, I like method chaining. I use it frequently and my primary argument to people is also "don't use it if you don't want it." However I would never encourage method chaining if the mutator didn't return an object of the same class as the object that received the message (or maybe with an isa relationship and with constructors being a special case). That's just begging Demeter to beat you to death. However, when I look at your code, I see one great big "catch-all" mutator where now I no longer can merely validate the values, but I also have to validate the names of the attributes. It would be easy to type this:

$window->set(title => 'foo', border => 20);

Depending on how someone codes that, it could easily silently fail when a direct method call would not.

I suppose we could argue all day long about which technique is better, but both of our preferred styles have strengths and weaknesses. For now I'll continue to return $self and you can continue to ignore it :)

Cheers,
Ovid

New address of my CGI Course.


In reply to Re^3: Mutator chaining NOT considered harmful by Ovid
in thread Mutator chaining considered harmful by Aristotle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others having an uproarious good time at the Monastery: (6)
As of 2024-04-19 07:28 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found