A simple optimization would be to replace
for (0..($strLen-1))
with
for ( 0..$strLen/2 )
One could get fancier by testing only those cycle lengths that are either 1 or prime factors of $strLen, which could make a difference for long strings.
Also, I think it's simpler just to test for equality of $str and $copy, obviating the xor and the regex:
for ( 1..$strLen/2 )
{
$copy .= substr $copy, 0, 1, '';
return wantarray ? ($_, substr $str, 0, $_) : $_
if $copy eq $str;
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|