I stopped reading at this part in Samba::LDAP:
if ( $self->{ldapTLS} == 1 ) {
$ldap_master->start_tls(
verify => $self->{verify},
clientcert => $self->{clientcert},
clientkey => $self->{clientkey},
cafile => $self->{cafile},
);
}
$ldap_master->bind( $self->{masterDN}, password => $self->{masterP
+w}, );
Please, please, please confirm that the requested TLS connection worked before you send a Domain Admin privileged account and password over the connection. The needed code looks like:
$ladp_master->code && die "failed to start TLS: ", $ldap_master->e
+rror ;
The same holds true for the _slave function.
Updated: Okay I read some more. I'm twitching about:
if ($homedir) {
my @rmargs = ('-rf');
# print "rm @rmargs $homedir\n";
system( 'rm', @rmargs, $homedir );
}
in Samba::LDAP::User. So many possible values of $homedir lead to ruin.
In general, there appears to be a lot of shelling out functionality that could be done in pure perl.
The intelligent reader will judge for himself. Without examining the facts fully and fairly, there is no way of knowing whether vox populi is really vox dei, or merely vox asinorum. — Cyrus H. Gordon
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.