comment on

That's what arrays and loops are for!

    my @c = split /,/, $hand;
    my $total = 0;

    # 2 cards
    for my $i1 (0..4) {
       for my $i2 ($i1+1..4) {
          $total += 2 if $c[$i1] + $c[$i2] == 15;
       }
    }

    # 3 cards
    for my $i1 (0..4) {
       for my $i2 ($i1+1..4) {
          for my $i3 ($i2+1..4) {
             $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] == 15;
          }
       }
    }

    ...
[download]

But we can do better.

    my @c = split /,/, $hand;
    my $total = 0;

    for my $i1 (0..4) {
        for my $i2 ($i1+1..4) {
            $total += 2 if $c[$i1] + $c[$i2] == 15;
            for my $i3 ($i2+1..4) {
                $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] == 15;
                for my $i4 ($i3+1..4) {
                    $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] + $c[$i
+4] == 15;
                    for my $i5 ($i4+1..4) {
                        $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] + $
+c[$i4] + $c[$i5] == 15;
                    }
                }
            }
        }
    }
[download]

Let's go further:

    my @c = split /,/, $hand;
    my $total = 0;

    our $sum;

    for my $i1 (0..4) {
        local $sum = $i1;
        for my $i2 ($i1+1..4) {
            local $sum = $sum + $c[$i2]];
            $total += 2 if $sum == 15;
            for my $i3 ($i2+1..4) {
                local $sum = $sum + $c[$i3];
                $total += 2 if $sum == 15;
                for my $i4 ($i3+1..4) {
                    local $sum = $sum + $c[$i4];
                    $total += 2 if $sum == 15;
                    for my $i5 ($i4+1..4) {
                        local $sum = $sum + $c[$i5];
                        $total += 2 if $sum == 15;
                    }
                }
            }
        }
    }
[download]

Let's add optimizations:

    my @c = split /,/, $hand;
    my $total = 0;

    our $sum;

    for my $i1 (0..4) {
        local $sum = $i1;
        for my $i2 ($i1+1..4) {
            local $sum = $sum + $c[$i2]];
            $total += 2 if $sum == 15;
            next if $sum >= 15;
            for my $i3 ($i2+1..4) {
                local $sum = $sum + $c[$i3];
                $total += 2 if $sum == 15;
                next if $sum >= 15;
                for my $i4 ($i3+1..4) {
                    local $sum = $sum + $c[$i4];
                    $total += 2 if $sum == 15;
                    next if $sum >= 15;
                    for my $i5 ($i4+1..4) {
                        local $sum = $sum + $c[$i5];
                        $total += 2 if $sum == 15;
                    }
                }
            }
        }
    }
[download]

While I eliminated a lot of redundancy both visually and in the number of checks, I'm sure there's still a better *algorithm*.

In reply to Re: calculating cribbage points by ikegami
in thread calculating cribbage points by dracos

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Clear questions and runnable code get the best and fastest answer
	PerlMonks