Great thread...and a very good issue raised...!!!
The problem I think is ...
1. That is too much on the same line.
2. And as its already been pointed out that anyone would read the code L to R...
The line looks like its been written to test someone's analytical ability rather than being easily readable and hence maintanable..
And I think thats more because of the 2nd problem...the second condition to be evaluated preceeds the first one in L to R order...
I guess the samething can be written in one line as below:
my $country = $card->country;
$country = ($country) ? ( ($country eq 'gbr') ? '' : uc "[$country]" )
+ : $country;
i think this is more readable....but agree with others that would be better to split this out..!!!!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||