I get the same complaint, on the same line.
False positive. It apparently doesn't check for local $_. I tend to avoid local $_ anyway. What follows is a list of alternatives.
(Note that chomp is probably redundant with s/\+s$//;, so I omitted it.)
my @files = map { my $s = $_; $s =~ s/^\s+//; $s =~ s/\+s$//; $s }
<$FILES>;
my @files = map { my $s = $_; for ($s) { s/^\s+//; s/\+s$//; } $s }
<$FILES>;
my @files = <$FILES>;
for (@files) { s/^\s+//; s/\+s$//; }
use List::MoreUtils qw( apply );
my @files = apply { s/^\s+//; s/\+s$//; } <$FILES>;
use Algorithm::Loops qw( Filter );
my @files = Filter { s/^\s+//; s/\+s$//; } <$FILES>;
Or turn off disable the critic for that instance, since you're only inadvertently modifying anonymous elements on the stack.
Do you need an array in the first place?
while (<$FILES>) {
s/^\s+//; s/\+s$//;
...
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.