I prefer interpolation over concatenation where possible because it seems less noisy to me. For example, I would change:

my @evil = map($_." evil",@lawful_vs_chaotic);
    return $prefix." ".$suffix;
[download]

to:

my @evil = map("$_ evil",@lawful_vs_chaotic);
    return "$prefix $suffix";
[download]

I have not decided whether or not I will ever upload it to CPAN

Your decision should be based on whether your code provides something that is not currently available on CPAN, according to results of a diligent search on your behalf. Does your code provide more functionality? Or, does it do so more efficiently (speed, memory)? Is it more robust or portable than something comparable? Is it more user-friendly (simpler to use, easier to download/install)?

If the answer to any of these questions is 'yes', then I would say it is a candidate for CPAN. In that case, your next step is to create a test suite. And to finish things off, I second ELISHEVA's advice regarding more standard POD sections.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.