Beefy Boxes and Bandwidth Generously Provided by pair Networks
Clear questions and runnable code
get the best and fastest answer
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
Using perlcritic -4 on my code I'm down to messages like:
Found use of die. Use an exception instead at line 38, column 8. Exce +ption objects should be used instead of the standard Perl error mechanism. (Severit +y: 4)

The 'offending' code is:

$hECO = retrieve($ECO_path) or die "Couldn't open $ECO_path : $!"; $hNIC = retrieve($NIC_path) or die "Couldn't open $NIC_path : $!"; $hOpening = retrieve($Opening_path) or die "Couldn't open $Opening_path : $!";

I'm wondering if the following is equivalent?

eval { $hECO = retrieve($ECO_path); 1; } or do { print "Couldn't open $ECO_path : $@"; exit; } eval { $hNIC = retrieve($NIC_path); 1; } or do { print "Couldn't open $NIC_path : $@"; exit; } eval { $hOpening = retrieve($Opening_path); 1; } or do { print "Couldn't open $Opening_path : $@"; exit; }

I'm also wondering if it is safe? What alternatives are there that don't drag in a mountain of dependencies? I've looked at Try::Tiny and TryCatch. Error is pretty much deprecated. If I have to I'll leave the code as is— but as a sort of intellectual challenge, I'd like to see what can be done.

--hsm

"Never try to teach a pig to sing...it wastes your time and it annoys the pig."

In reply to eval to replace die? by hsmyers

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others studying the Monastery: (3)
As of 2024-03-29 02:14 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found