It would be pretty unusual to have a file name that ends with \n, so I see that as an edge case that's probably not worth worrying about.
It's probably better to have a check after the call to RRDs::info, so I've inserted:
my $info = RRDs::info "$logsdir/$rrd";
# Check to ensure we actually have a valid rrd file
unless ($info->{filename}) {
print qq|"$logsdir/$rrd" doesn't appear to be a valid rrd log,
+ skipping\n|;
next;
}
Which does the trick...
$ touch foo.rrd
$ ./rrd-resize.pl
Starting, found 1 rrd files
Processing foo.rrd
"./foo.rrd" doesn't appear to be a valid rrd log, skipping
Finished, processed 1 files in 0.00 seconds
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|