I would write is as follows:

#!/usr/bin/perl -w
     
use strict;
use Net::SNMP;

Usage () unless @ARGV == 2; 

my ($session, $error) = Net::SNMP -> session (
    -hostname  => $ARGV [0],
    -community => $ARGV [1],
);

$session or die "Session error: $error";
                
my $tableid = "1.3.6.1.4.1.1991.1.1.4.6.1.1";
my $table   =  $session -> get_table ($tableid)
                or die "request error: ", $session -> error;
foreach my $oid (keys %$table) {
    if ($oid =~ /^\Q$tableid\E\.(\d+)/) {
        print "Real server ",                  $table -> {$oid},
              ", port ",                       $table -> {"$tableid.5.
+$1"},
              ", is bound to virtual server ", $table -> {"$tableid.2.
+$1"},
              ", on port ",                    $table -> {"$tableid.3.
+$1"},
              "\n";
    }
}

my $sysid      = "1.3.6.1.2.1.1.4.0";
my $syscontact = $session -> get_request ($sysid)
                  or die "Request error: ", $session -> error;
print "For help or questions contact: ", $syscontact -> {$sysid}, "\n"
+;

$session -> close;
[download]

Some differences: no global variables (with use vars). No magical constants that are repeated. Taken care of the special meaning of a dot inside a regex. Anchored the regex. Used parenthesis to capture relevant field. No needless concatenation in print or die. Success is checked right away and not in a separate statement. Just one check to see if there are enough arguments.

-- Abigail

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.