Hi tobyink,
Thank you for replying. You, Neighbour, and the other Monks really helped me out. But I wanted to ask you how should I close the filehandle $fh after it has been opened?
I've written my code somewhat similar to you and Neighbours but I am not sure if it is correct. Here is a snippet of the problem:
sub my_close {
my( $fh ) = @_;
+
close($fh) or die "$!\n";
}
+
sub my_open {
+
my( $file, $mode ) = @_;
+
open my $fh, $mode, $file or die "$!\n";
+
return $fh;
}
sub errors {
+
my( $file, $mode ) = @_;
my $fh = my_open($file, $mode);
my @errors = ();
while( <$fh> ) {
chomp;
+
next if /^[a-z]/;
push( @errors, qq(Line $. '$_' does not begin with lowercase l
+etter.) );
}
my_close($fh); # Safe to close file like this???
+
+
return @errors;
}
Thank you.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|