Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re: Re^4: My coding guidelines (utopian)

by demerphq (Chancellor)
on Apr 13, 2004 at 16:02 UTC ( #344771=note: print w/replies, xml ) Need Help??

in reply to Re^4: My coding guidelines (utopian)
in thread My coding guidelines

I find such attempts to be very annoying anyway, so I don't consider this a big hurdle. Even Code Complete notes how evil such practices are.

Ive read what code complete has to say on this, and I wont argue against the view this is bad. But personally I find that I use such reorganization as a comfortable place to do something mindless with the code while meditating on the code. Ive noticed that when i am very clear on what I want to do and what the code already does I dont bother with such things, but when the code is new, or the ideas fresh I spend endless amounts of time realigning things. And I dont consider it time wasted.

Out of curiousity does your dislike of this stems from writing code such that it does line up or from reading code which already does? I ask partially because most of my patches here have some form of internal vertical alignment in them, and I wonder if it really puts you off so much?


    First they ignore you, then they laugh at you, then they fight you, then you win.
    -- Gandhi

Replies are listed 'Best First'.
Re^6: My coding guidelines (utopian)
by tye (Sage) on Apr 13, 2004 at 16:35 UTC

    I'm of mixed feelings with vertical alignment of things on separate lines where the lines are indented to the same level. I often won't bother but sometimes do and even (sometimes reluctantly) admit that such can make the code easier to read, though I find that it can clearly be taken too far. For example, lining up punctuation just boggles me even though I've seen code like this:

    my $i = 1 ; my $maxPercentDebit = 100.0+($i/100.0); $i = int ( $i ); $maxPercentDebit = normalizePercentage( $maxPercentDebit );

    But I really hate lining up indentation of a line to match the length of code on a previous line. So I'll often rewrite code such as:

    $maxPercentDebit = normalizePercentage( $i, $maxPercentDebit );

    to something more like

    $maxPercentDebit = normalizePercentage( $i, $maxPercentDebit );

    (especially assuming a much longer list of arguments such that it doesn't make sense to group the arguments into a single line).

    I even prefer to treat () more like {} and write:

    $maxPercentDebit = normalizePercentage( $i, $maxPercentDebit, );

    and in C where the extra trailing comma isn't tollerated, I'd really like to use:

    maxPercentDebit = normalizePercentage( i , maxPercentDebit );

    but hold no hope of getting any of my current cow orkers to see the beauty in that. (:

    - tye        

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://344771]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (4)
As of 2017-01-23 03:22 GMT
Find Nodes?
    Voting Booth?
    Do you watch meteor showers?

    Results (190 votes). Check out past polls.