Beefy Boxes and Bandwidth Generously Provided by pair Networks Bob
Just another Perl shrine
 
PerlMonks  

Re: Including files

by Aristotle (Chancellor)
on Sep 26, 2004 at 16:16 UTC ( #393966=note: print w/ replies, xml ) Need Help??


in reply to Including files

You probably want to fix this:

my $code = join( "\n", qq[#line 1 "$filename"], File::Slurp::read_file($filename) );

You provide list context to read_file, only to then glue all the lines back together anyway. Except that you didn't chomp them, so joining with \n doubles all EOLs which throws off your line numbers. You want a simple concatenation instead.

my $code = qq[#line 1 "$filename"\n] . File::Slurp::read_file($filenam +e);

Very nice work on the node.

Makeshifts last the longest.


Comment on Re: Including files
Select or Download Code
Re^2: Including files
by Juerd (Abbot) on Sep 26, 2004 at 20:24 UTC

    You provide list context to read_file, only to then glue all the lines back together anyway.

    Oops. That join is a left over bit of an earlier, more complex, attempt. Because Perl doesn't care about double newlines, and I didn't test with multi-line strings, and haven't even looked at line numbers, I never noticed that anything was wrong.

    You are of course right that simple concatenation is better here. I'll update the node right away.

    Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://393966]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (6)
As of 2014-04-20 10:49 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    April first is:







    Results (485 votes), past polls