Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: The joys of bad code

by TomDLux (Vicar)
on Nov 15, 2004 at 19:01 UTC ( #407904=note: print w/replies, xml ) Need Help??

in reply to The joys of bad code

Came across some code I just had to share. How many steps is this programmer from good, idiomatic perl?

sub padfield { my ( $value, $fieldlength ) = @_; while ( length $value < $fieldlength ) { my $pad = '0'; $value = join( '', $pad, $value ); } return $value; }
  1. A creative use of join(). But why not just use simple string contcatenation: $value = $pad . $value ?
  2. You could use the string repetition operator $value = ("0" x ($fieldlength - length $value )) . $value.
  3. Or you could use take the right substring of an over-padded string.
  4. But even a C or Java programmer should know printf padded formats: return sprintf "%0$fieldlengthd", $value.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://407904]
[Discipulus]: good morning monks!
[Your Mother]: Mooooooooooorning.

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (7)
As of 2017-07-21 07:35 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (319 votes). Check out past polls.