But then I forgot to re-escape the cookie… patch and root node updated.
Makeshifts last the longest.
| [reply] [Watch: Dir/Any] |
And it's still broken. :-)
I just got around to using your updated version instead of my hackery, and noticed it didn't work. Here's a fix:
--- pmchat.html.old 2004-12-19 20:12:15.000000000 -0500
+++ pmchat.html 2004-12-19 20:07:59.000000000 -0500
@@ -15,7 +15,7 @@
var record = str.split( /\s*;\s*/ );
for( var i = 0; i < record.length; ++i ) {
var kv = record[ i ].split( /=/ );
- this.data[ decodeURIComponent( kv[ 0 ] ) ] = d
+ecodeURIComponent( kv[ 1 ] );
+ this.data[ decodeURIComponent( kv[ 0 ].replace
+(/%25/g, '%') ) ] = decodeURIComponent( kv[ 1 ].replace(/%25/g, '%')
+);
}
},
get: function( key ) {
PM seems to double-encode or something -- at the least, percents (%) are replaced with %25 in the already URL encoded string. It doesn't seem to care if you do the reverse or not when re-encoding it.
| [reply] [Watch: Dir/Any] [d/l] |
--- pmchatter.html.old 2004-12-20 02:49:00.000000000 +0100
+++ pmchatter.html 2004-12-20 02:49:03.000000000 +0100
@@ -34,3 +34,3 @@
- try{ cookie.parse( this.req.getResponseHeader( 'Set-Co
+okie' ) ); }
+ try{ decodeURIComponent( cookie.parse( this.req.getRes
+ponseHeader( 'Set-Cookie' ) ) ); }
catch( e ) { }
Makeshifts last the longest.
| [reply] [Watch: Dir/Any] [d/l] |