Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re^2: I present to you... Horrible code!

by itub (Priest)
on Jan 08, 2005 at 15:18 UTC ( #420532=note: print w/ replies, xml ) Need Help??


in reply to Re: I present to you... Horrible code!
in thread I present to you... Horrible code!

There is one minor error: your @quarters array is zero-based, but the quarter as passed to the method counts from 1 ($quarters[1] is "second").

Should the "2" passed to "error" be a named constant instead of a magic number? Who knows, perhaps if this is an error level number a number is not that bad. If you turn the error levels into names, make sure that they are clear, unlike the US Homeland Security Advisory System (I always have trouble remembering whether "high" is higher than "elevated" or the other way around ;-) )


Comment on Re^2: I present to you... Horrible code!
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://420532]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (12)
As of 2014-09-30 12:38 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    How do you remember the number of days in each month?











    Results (368 votes), past polls