Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

Re: SpamAssassin / Amavis-new / Clam-AV

by nothingmuch (Priest)
on Jul 10, 2005 at 10:31 UTC ( #473747=note: print w/ replies, xml ) Need Help??


in reply to SpamAssassin / Amavis-new / Clam-AV

  • This seems in order: sub fmt_percent { sprintf("...", $_[0] }
  • I would try to do away with most of the file scoped vars (my $tt) etc, by trying to consolidate the logic that drives them into single expressions... I find that reading an expression in one go has more of a mnemonic effect than many variables which are similar in nature. This only works to some extent, though.
  • I like your use of grep in scalar context
  • I don't like your use of print-like-a-function.... You can omit the parens.
  • I'm not sure, but maybe my @files = glob("/var/log/maillog*") is in order
Aside from that, this is good code, readable, well structured, and so forth. I'm assuming it was formatted more structuredly before it was posted ;-)

Ciao!

-nuffin
zz zZ Z Z #!perl


Comment on Re: SpamAssassin / Amavis-new / Clam-AV
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://473747]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (7)
As of 2014-07-28 06:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (191 votes), past polls