note
Codon
Let me make one suggestion that may seem obvious to someone that has not been looking at this code before (You know that phenomenon where you look at the same block of code for hours trying to find the bug and then finally go ask someone to help you out and they point out the obvious error before you finish explaining the problem?). If you have an <c>if ( ! some_test() )</c>, it is generally more readable to say <c>unless ( some_test() )</c>. So using this logic
<c>
if ( ! $NONFATALERROR == 0 ) {
...
}
</c>
becomes
<c>
unless ( $NONFATALERROR == 0 ) {
...
}
</c>
which is really
<c>
unless ( ! $NONFATALERROR ) {
...
</c>
because any non-zero value (<c>undef</c> evaluates to 0 in this context) is TRUE. Using the same aurgument against <c>unless ( ! some_test() )</c> as we did against <c>if ( ! some_test() )</c>, we then get
<c>
if ( $NONFATALERROR ) {
...
}
</c>
It's nitpicking, to be sure, but minor changes can have major benefit for anyone that has to maintain the code later, even the original author.
<p>
<!-- Node text goes above. Div tags should contain sig only -->
<div class="pmsig"><div class="pmsig-454503">
<small>Ivan Heffner<br>
Sr. Software Engineer, DAS Lead<br>
WhitePages.com, Inc.</small>
</div></div>
492258
492258