Re^2: Miscellaneous.pm?

[markjugg]

in reply to Re: Miscellaneous.pm?
in thread Miscellaneous.pm?

Are you aware of List::MoreUtils? It contains a "uniq" function much like this.

BTW, there seems to be bug in your routine. I think you meant something like !$seen{$_}++.

That illustrates the value of having even a "simple" routine in a re-usable module!

[diotalevi]

That module is on my to-avoid list. It's poisoned with prototypes and is chock full of functions of dubious utility and quality. Thanks for the note about the bug in my response. I don't make the same mistake when I'm typing at source code.

In general, I'd prefer to inline these sorts of tasks anyway. It's only while experimenting that I use these as broken out functions.

[bart]

Thanks for the note about the bug in my response. I don't make the same mistake when I'm typing at source code.

LOL! Yeah, right. You've shown a perfect example why people ought to put such often used code in a module, instead of typing it in, again and again.

[diotalevi]

Well I've never made it /before/...

[polettix]

[List::MoreUtils]... is chock full of functions of dubious utility and quality.

Could you elaborate a bit about the quality? Just curious, could be an interesting source for guidelines and best practices (and probably a meditation by its own).

[diotalevi]

I objected most to the use of prototypes everywhere. I might have found one thing I disliked but I was sure I'd get things wrong if I used it because it's a bag of functions and it'd force some particular syntax on me.

I kind of sort of wish that if the author really believed in those functions that they'd be added to List::Utils directly.