Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things

Re^2: Ideas Wanted for Perl::Critic Security Policies

by davidrw (Prior)
on Jul 01, 2006 at 00:40 UTC ( #558708=note: print w/replies, xml ) Need Help??

in reply to Re: Ideas Wanted for Perl::Critic Security Policies
in thread Ideas Wanted for Perl::Critic Security Policies

Using the 3-parameter form of open would be a good practice to check for.
There's a InputOutput::ProhibitTwoArgOpen in the Perl::Critic distro already..

The DBI one would be a 'challenge' :) .. not sure how it'd be possible to distinguish between $dbh->prepare("update table set my_val = $somevalue") (NOT OK) and $dbh->prepare("update $TABLENAME set my_val = ?") (OK) without actually parsing the sql .. plus there's the circumvention of $sql = "update table set my_val = $somevalue"; $sth=$dbh->prepare($sql); as well (or can you back-trace that w/PPI?)..

I took a crack at the system/exec one (see RFC: Perl-Critic policy: ProhibitInlineSystemArgs), though i think there's problems catching all of those, too.. e.g. system( join(" ", $cmd, @args) )

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://558708]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (6)
As of 2017-12-12 23:09 GMT
Find Nodes?
    Voting Booth?
    What programming language do you hate the most?

    Results (340 votes). Check out past polls.