Re^3: Follow up to RFC: Templating without a System (required)

[tye]

So, not only are you using an undocumented feature of require, but you are also using it in a manner contrary to its purpose. In a code review, I'd reject such use unless you documented and enforced your unusual requirements. That is, you should check %INC before requireing so you can report that the file got required already (and include a comment about why that matters and that the feature of require that you are depending on is not documented).

Even better, Perl already has a tool that does what you are using require for: do $file. Use that instead.

[shmem]

Right, I'll use do. It just does what I want.

I have to use require for the same reasons AutoLoader uses require and not just do FILE. do FILE, when wrapped in a string eval

    my $sub = eval "package $package; do '$file'";

doesn't set $@ outside the eval. require dies, do does not. $sub is just undef, nothing more, and all I can do is mumble "something went wrong while 'do $file' at line $foo" which ain't any good.

I need require; requiring a file twice happens only at development time (or if you do funny things like generating template source on the fly and ask for trouble unless you know what you're doing); it provides for re-compiling on the fly and shortens turnaround time.

I'll include an argument to the package's import() function - recompile_on_change - which will enable such behaviour, and note the implications prominently in the code and in the pod.

Does that stand to your scrutiny?

thanks for the hint again,

--shmem