|Think about Loose Coupling|
Re: Request for Perl::Critic Testimonials (some weirdnesses of the module)by Ieronim (Friar)
|on Jul 15, 2006 at 18:34 UTC||Need Help??|
The most weird error messages i get from Perl::Critic are those:
They look very funny when they both refer to the line like this:
I think you can set a length limit for the regular expressions to receive a warning about /x flag. Maybe, regexes shorter than e.g. 7 characters do not need /x flag? Or even better—remove warnings for regexes containing less than 5 metacharacters, e.g. /(foo|bar)/? The regexes containing only ONE interpolated variable (like the one mentioned below) must not cause them, too.
The warning about /m simply looks weird for me though I can understand why do you use it. But it must not appear to the lines like
The next bug: the line
causes two warnings:
while it must cause only the second warning! To use or not to use the punctuation variables is some kind of personal style, but not local'izing them is a severe error!
A little tip about the web-interface: You could add a possibility for the user to re-sort your warnings list by severity or by categories. The list would also look much better if it was represented by a table rather than by a simple linklist :)Despite all my remarks you have done a great work ad i hope that my comments will help you to improve it :)
Sorry for my bad English—it's not my native language :)