Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re^3: Mad, bad and dangerous to know

by davorg (Chancellor)
on Jul 31, 2006 at 15:29 UTC ( #564768=note: print w/ replies, xml ) Need Help??


in reply to Re^2: Mad, bad and dangerous to know
in thread Mad, bad and dangerous to know

Do you really think that Matt's code is easy to read? I think it looks horrible. It's massively overcomplicated, it's full of outdated Perl 4 idioms and it doesn't make any use of modules which would reduce it in length by about a half.

But my biggest problem with it is the number of people who have written other bad code following Matt's example. I'd guess that at least half of the broken, hand-coded CGI parsers that I see are based on Matt's code.

Update: It's also worth noting that whilst the latest version of Matt's formmail is (as far as I can see) free from security holes, older versions that are famously insecure are still in use on hundreds of web servers.

I know that the nms versions of the program are more secure and better written. I hope that they are also easier to read.

--
<http://dave.org.uk>

"The first rule of Perl club is you do not talk about Perl club."
-- Chip Salzenberg


Comment on Re^3: Mad, bad and dangerous to know
Re^4: Mad, bad and dangerous to know
by gellyfish (Monsignor) on Jul 31, 2006 at 15:33 UTC

    I'm pretty certain that the "un-webify" code that is everywhere came from some early Matt program.

    ?J\

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://564768]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (12)
As of 2014-10-20 22:04 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (92 votes), past polls