Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW

Re^3: Mad, bad and dangerous to know

by davorg (Chancellor)
on Jul 31, 2006 at 15:29 UTC ( #564768=note: print w/replies, xml ) Need Help??

in reply to Re^2: Mad, bad and dangerous to know
in thread Mad, bad and dangerous to know

Do you really think that Matt's code is easy to read? I think it looks horrible. It's massively overcomplicated, it's full of outdated Perl 4 idioms and it doesn't make any use of modules which would reduce it in length by about a half.

But my biggest problem with it is the number of people who have written other bad code following Matt's example. I'd guess that at least half of the broken, hand-coded CGI parsers that I see are based on Matt's code.

Update: It's also worth noting that whilst the latest version of Matt's formmail is (as far as I can see) free from security holes, older versions that are famously insecure are still in use on hundreds of web servers.

I know that the nms versions of the program are more secure and better written. I hope that they are also easier to read.


"The first rule of Perl club is you do not talk about Perl club."
-- Chip Salzenberg

Replies are listed 'Best First'.
Re^4: Mad, bad and dangerous to know
by gellyfish (Monsignor) on Jul 31, 2006 at 15:33 UTC

    I'm pretty certain that the "un-webify" code that is everywhere came from some early Matt program.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://564768]
[Lady_Aleena]: LanX, I just never thought I would be explaining perl regex to others. It is usually others explaining why a regex isn't working to me.
[Discipulus]: congratulations shmem! (was my last upvote? ;=)

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (2)
As of 2017-04-28 09:54 GMT
Find Nodes?
    Voting Booth?
    I'm a fool:

    Results (520 votes). Check out past polls.